Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around release build blocker due to whl_no_aio test environment #40313

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

ralph-msft
Copy link
Member

  • renamed test_prompty.py to test_prompt_async.py so that those tests get skipped in whl_no_aio since they are async test cases testing async functions
  • updated the names of the test recording files so that they still match and verified that recording playback still works

@Copilot Copilot bot review requested due to automatic review settings April 1, 2025 18:18
@ralph-msft ralph-msft requested a review from a team as a code owner April 1, 2025 18:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • sdk/evaluation/azure-ai-evaluation/assets.json: Language not supported

@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Apr 1, 2025
@ralph-msft ralph-msft changed the title Work around release build due to whl_no_aio test environment Work around release build blocker due to whl_no_aio test environment Apr 1, 2025
@ralph-msft ralph-msft enabled auto-merge (squash) April 1, 2025 18:19
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@ralph-msft ralph-msft merged commit 21d868d into Azure:main Apr 1, 2025
23 checks passed
weirongw23-msft pushed a commit to weirongw23-msft/azure-sdk-for-python that referenced this pull request Apr 4, 2025
…0313)

- renamed `test_prompty.py` to `test_prompt_async.py` so that those tests get skipped in whl_no_aio since they are async test cases testing async functions
- updated the names of the test recording files so that they still match and verified that recording playback still works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants