Minor fixes to RedTeam #40310
Merged
Minor fixes to RedTeam #40310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces minor fixes to the RedTeam component by updating the dependency specifier in setup.py and adding try/except blocks to handle potential exceptions when computing attack success rates in the red team result logic.
- Updated the dependency specifier for the "redteam" extra in setup.py.
- Wrapped multiple attack success rate calculations in try/except blocks in _red_team.py for improved error handling.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/setup.py | Modified the dependency version specifier for redteam. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_red_team/_red_team.py | Added try/except blocks around metric calculations and updated logging messages. |
Files not reviewed (1)
- sdk/evaluation/azure-ai-evaluation/dev_requirements.txt: Language not supported
|
API change check API changes are not detected in this pull request. |
nagkumar91
approved these changes
Apr 1, 2025
slister1001
commented
Apr 1, 2025
weirongw23-msft
pushed a commit
to weirongw23-msft/azure-sdk-for-python
that referenced
this pull request
Apr 4, 2025
* small fixes * typo * undo dev requirements change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines