-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage visibility #40309
base: main
Are you sure you want to change the base?
Code coverage visibility #40309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses improvements in code coverage reporting and minor code style clarifications.
- In the compute module, the inline comment has been updated for consistency.
- In the tox runner, an additional log statement has been added to report package coverage.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute.py | Updated inline comment wording for consistency. |
eng/tox/run_coverage.py | Added a logging.info call to display the coverage percentage. |
eng/tox/run_coverage.py
Outdated
f"Coverage for {pkg_details.name} is {total_coverage:.2f}%)" | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be an extra closing parenthesis in the logging message. Removing it will ensure the message is correctly formatted.
f"Coverage for {pkg_details.name} is {total_coverage:.2f}%)" | |
) | |
f"Coverage for {pkg_details.name} is {total_coverage:.2f}%" |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
API change check APIView has identified API level changes in this PR and created following API reviews. |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines