Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage visibility #40309

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Code coverage visibility #40309

wants to merge 3 commits into from

Conversation

pdhotems
Copy link
Member

@pdhotems pdhotems commented Apr 1, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot bot review requested due to automatic review settings April 1, 2025 10:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses improvements in code coverage reporting and minor code style clarifications.

  • In the compute module, the inline comment has been updated for consistency.
  • In the tox runner, an additional log statement has been added to report package coverage.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute.py Updated inline comment wording for consistency.
eng/tox/run_coverage.py Added a logging.info call to display the coverage percentage.

Comment on lines 77 to 79
f"Coverage for {pkg_details.name} is {total_coverage:.2f}%)"
)

Copy link
Preview

Copilot AI Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be an extra closing parenthesis in the logging message. Removing it will ensure the message is correctly formatted.

Suggested change
f"Coverage for {pkg_details.name} is {total_coverage:.2f}%)"
)
f"Coverage for {pkg_details.name} is {total_coverage:.2f}%"

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants