Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoRelease] t2-edgezones-2025-04-01-86237(can only be merged by SDK owner) #40307

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

azure-sdk
Copy link
Collaborator

https://github.com/Azure/sdk-release-request/issues/5981
Recording test fail, detailed info is in pipeline log(search keyword FAILED)!!!
https://dev.azure.com/azure-sdk/internal/_build?definitionId=6976

@azure-sdk
Copy link
Collaborator Author

@Copilot Copilot bot review requested due to automatic review settings April 1, 2025 08:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses auto release changes for the Edge Zones management client in the Azure SDK. Key updates include:

  • Consistent application of URL formatting using path format arguments across synchronous and asynchronous pipelines.
  • Enhanced type annotations and error deserialization using _failsafe_deserialize.
  • Adjustments to model field visibility and minor improvements in import organization and documentation.

Reviewed Changes

Copilot reviewed 26 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/edgezones/azure-mgmt-edgezones/generated_samples/*.py Added and updated sample code for operations, extended zones register/unregister, list, and get.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/operations/_operations.py Improved type hints, error deserialization, and URL formatting logic in operations methods.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/operations/init.py Updated import order and added TYPE_CHECKING guard.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/models/*.py Added visibility settings to rest_field properties in resource models.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/aio/operations/* Similar URL formatting and error deserialization updates applied in asynchronous operations.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/aio/_client.py Updated URL formatting in the async client by applying consistent path arguments.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/aio/_configuration.py Added base_url parameter to the async configuration.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_configuration.py Added base_url parameter and updated constructor signature.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/_client.py Adjusted URL formatting logic in the synchronous client.
sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/init.py Updated import organization and TYPE_CHECKING usage.
sdk/edgezones/azure-mgmt-edgezones/README.md Corrected a typo in the authentication documentation.
Files not reviewed (2)
  • sdk/edgezones/azure-mgmt-edgezones/_meta.json: Language not supported
  • sdk/edgezones/azure-mgmt-edgezones/apiview-properties.json: Language not supported
Comments suppressed due to low confidence (1)

sdk/edgezones/azure-mgmt-edgezones/azure/mgmt/edgezones/operations/_operations.py:317

  • [nitpick] The use of the literal string 'self._config.base_url' as the field name in the serialization call may be unclear. Consider using a more descriptive constant or parameter name to clearly indicate its purpose.
                "endpoint": self._serialize.url("self._config.base_url", self._config.base_url, "str", skip_quote=True)

@ChenxiJiang333 ChenxiJiang333 merged commit b87fc53 into Azure:main Apr 1, 2025
21 checks passed
@azure-sdk azure-sdk deleted the t2-edgezones-2025-04-01-86237 branch April 6, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants