Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK generation pipeline] fix version logic #40305

Merged
merged 2 commits into from
Apr 1, 2025
Merged

[SDK generation pipeline] fix version logic #40305

merged 2 commits into from
Apr 1, 2025

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Apr 1, 2025

  • remove unused code
  • update version with next version if next version is valid

@Copilot Copilot bot review requested due to automatic review settings April 1, 2025 02:30
@msyyc msyyc requested review from scbedd and mccoyp as code owners April 1, 2025 02:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses improvements in the SDK generation pipeline by removing unused code and ensuring that the package version is updated to the next valid version when applicable. Key changes include:

  • Removal of an obsolete built package block in sdk_package.py.
  • Reordering the code in sdk_package.py to update the package version from check_file before building the package.
  • Modifications in package_utils.py to allow check_file to update the package version based on the next valid version.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/azure-sdk-tools/packaging_tools/sdk_package.py Reordered built package calls and updated version logic for azure-mgmt- packages.
tools/azure-sdk-tools/packaging_tools/package_utils.py Removed unused package getters and updated check_file to modify the package version when applicable.

@msyyc
Copy link
Member Author

msyyc commented Apr 1, 2025

/check-enforcer override

@msyyc msyyc merged commit 0b0345a into main Apr 1, 2025
25 of 27 checks passed
@msyyc msyyc deleted the update-pipeline branch April 1, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants