fix-positional-argument #40296
Merged
fix-positional-argument #40296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with positional arguments by converting parameters to keyword-only in evaluator constructors.
- Updated the RelevanceEvaluator init to enforce 'threshold' as a keyword-only argument.
- Updated the ContentSafety evaluator init to enforce threshold parameters as keyword-only.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_relevance/_relevance.py | Updated init signature to use keyword-only 'threshold' |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_content_safety/_content_safety.py | Updated init signature to use keyword-only thresholds |
github-actions
bot
added
the
Evaluation
kashifkhan
approved these changes
Mar 31, 2025
slister1001
approved these changes
Mar 31, 2025
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
nagkumar91
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.