Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] app config issue #40295

Merged
merged 1 commit into from
Mar 31, 2025
Merged

[bug] app config issue #40295

merged 1 commit into from
Mar 31, 2025

Conversation

l0lawrence
Copy link
Member

@l0lawrence l0lawrence commented Mar 31, 2025

#39274 the way the pipeline is set up for app config, analyze runs twice, once for provider and once for app-config, but analyze runs both packages so it duplicates the errors. Could also update its test.yml in addition since that seems excessive imo

@l0lawrence
Copy link
Member Author

l0lawrence commented Mar 31, 2025

/azp run python - appconfiguration - tests-weekly

Copy link

Command 'python' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@l0lawrence l0lawrence marked this pull request as ready for review March 31, 2025 18:07
@Copilot Copilot bot review requested due to automatic review settings March 31, 2025 18:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses a bug where duplicate error messages are posted due to the pipeline analyzing both the provider and app-config packages simultaneously. Key changes include:

  • Updating the condition to append Pylint errors only if the issue body does not already include a "Pylint Errors:" section.
  • Adding an inline comment clarifying the intention behind the conditional block in the issue edit logic.
Comments suppressed due to low confidence (1)

tools/azure-sdk-tools/gh_tools/update_issue.py:72

  • Consider verifying that issue.body contains the delimiter 'How to fix:' before taking the second element of the split, to prevent a potential IndexError.
new_body = first_section + template + "\n" + issue.body.split("**How to fix:**")[1]

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that App Config might want to simplify their pipeline, but this solves the problem and doesn't hurt

@l0lawrence l0lawrence merged commit f523b34 into Azure:main Mar 31, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants