-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] app config issue #40295
[bug] app config issue #40295
Conversation
/azp run python - appconfiguration - tests-weekly |
Command 'python' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request addresses a bug where duplicate error messages are posted due to the pipeline analyzing both the provider and app-config packages simultaneously. Key changes include:
- Updating the condition to append Pylint errors only if the issue body does not already include a "Pylint Errors:" section.
- Adding an inline comment clarifying the intention behind the conditional block in the issue edit logic.
Comments suppressed due to low confidence (1)
tools/azure-sdk-tools/gh_tools/update_issue.py:72
- Consider verifying that issue.body contains the delimiter 'How to fix:' before taking the second element of the split, to prevent a potential IndexError.
new_body = first_section + template + "\n" + issue.body.split("**How to fix:**")[1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that App Config might want to simplify their pipeline, but this solves the problem and doesn't hurt
#39274 the way the pipeline is set up for app config, analyze runs twice, once for provider and once for app-config, but analyze runs both packages so it duplicates the errors. Could also update its test.yml in addition since that seems excessive imo