-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoRelease] t2-arizeaiobservabilityeval-2025-03-31-95383(can only be merged by SDK owner) #40286
[AutoRelease] t2-arizeaiobservabilityeval-2025-03-31-95383(can only be merged by SDK owner) #40286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the initial version of the Azure management client for ArizeAIObservabilityEval, including both asynchronous (aio) and synchronous implementations along with supporting configuration, patch, models, and documentation files.
- Introduces new modules for client configuration, request handling, and operations in both sync and async flavors.
- Adds generated models, versioning, and patch customization to support expanded functionality.
- Provides updated README and CHANGELOG files documenting the release history.
Reviewed Changes
Copilot reviewed 45 out of 49 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
models/init.py | Exports all model classes and integrates patch customizations. |
aio/operations/_patch.py | Creates asynchronous patch helper for operations. |
aio/operations/init.py | Exports async operations classes with patch integration. |
aio/_patch.py | Provides asynchronous patch customization hooks. |
aio/_configuration.py | Implements client configuration for async operations with policies. |
aio/_client.py | Defines the async management client including request sending and context management. |
aio/init.py | Initializes the async client package with patch integration. |
_version.py | Defines the version of the SDK. |
_patch.py | Provides synchronous patch customization hooks. |
_configuration.py | Implements client configuration for the sync operations with policies. |
_client.py | Defines the sync management client including request sending and context management. |
init.py (mgmt and azure) | Sets up package namespace and path extension. |
README.md | Updates package documentation and usage instructions. |
CHANGELOG.md | Documents the initial release history. |
Files not reviewed (4)
- sdk/arizeaiobservabilityeval/azure-mgmt-arizeaiobservabilityeval/LICENSE: Language not supported
- sdk/arizeaiobservabilityeval/azure-mgmt-arizeaiobservabilityeval/MANIFEST.in: Language not supported
- sdk/arizeaiobservabilityeval/azure-mgmt-arizeaiobservabilityeval/_meta.json: Language not supported
- sdk/arizeaiobservabilityeval/azure-mgmt-arizeaiobservabilityeval/apiview-properties.json: Language not supported
Comments suppressed due to low confidence (3)
sdk/arizeaiobservabilityeval/azure-mgmt-arizeaiobservabilityeval/aio/_client.py:55
- The use of a literal placeholder for _endpoint may be unclear. If the intention is to dynamically format the URL using self._config.base_url via the subsequent call to format_url, please consider adding an inline comment or using self._config.base_url directly to improve readability.
_endpoint = "{endpoint}"
sdk/arizeaiobservabilityeval/azure-mgmt-arizeaiobservabilityeval/aio/_client.py:74
- Including a None value in the policies list (when self._config.redirect_policy is falsy) might lead to unintended behavior in the pipeline. Consider filtering out or conditionally adding this policy to ensure the policies list contains only valid policy objects.
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
sdk/arizeaiobservabilityeval/azure-mgmt-arizeaiobservabilityeval/aio/_configuration.py:65
- Using the synchronous NetworkTraceLoggingPolicy in an asynchronous configuration may not be appropriate. Please verify that this policy is compatible with async operations or consider using an async-capable alternative.
self.logging_policy = kwargs.get("logging_policy") or policies.NetworkTraceLoggingPolicy(**kwargs)
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
https://github.com/Azure/sdk-release-request/issues/5935
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=7569