Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code coverage threshold #40272

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Reduce code coverage threshold #40272

merged 1 commit into from
Mar 31, 2025

Conversation

pdhotems
Copy link
Member

@pdhotems pdhotems commented Mar 28, 2025

Description

Reduce the code coverage threshold

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot bot review requested due to automatic review settings March 28, 2025 11:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the code coverage threshold configuration and makes a minor comment punctuation change for clarity.

  • Adjusts the coverage threshold value in the configuration file.
  • Updates an inline comment to include a period for consistency.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/ml/azure-ai-ml/pyproject.toml Updated the coverage percentage from a float to an integer.
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute.py Minor punctuation change in an inline comment for consistency.
Comments suppressed due to low confidence (2)

sdk/ml/azure-ai-ml/pyproject.toml:10

  • The change from a float value (65.50) to an integer (65) may affect coverage calculations if precision was required. Confirm that the new threshold value is intentional.
absolute_cov_percent = 65

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute.py:183

  • [nitpick] The inline comment has a punctuation change (addition of a period) compared to similar comments in the code. Consider aligning the punctuation style for consistency.
compute_type = type_in_override or data.get(CommonYamlFields.TYPE, None)  # override takes the priority.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@pdhotems pdhotems changed the title update code coverage Reduce code coverage threshold Mar 31, 2025
@pdhotems pdhotems merged commit 74f7683 into main Mar 31, 2025
31 checks passed
@pdhotems pdhotems deleted the pdhote/code-cov-threshold branch March 31, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants