Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating the formatting of completeness based on other prompt templates. #40267

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

updating the formatting of completeness based on other prompt templates. #40267

wants to merge 5 commits into from
+31 −46

Conversation

guptha23
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot bot review requested due to automatic review settings March 28, 2025 10:10
@guptha23 guptha23 requested a review from a team as a code owner March 28, 2025 10:10
Copilot
Copilot AI reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_response_completeness/response_completeness.prompty: Language not supported

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Evaluation Issues related to the client library for Azure AI Evaluation labels Mar 28, 2025
@github-actions GitHub Actions
Copy link

Thank you for your contribution @guptha23! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

JoseCSantos
JoseCSantos approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@JoseCSantos JoseCSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@annatisch annatisch removed customer-reported Issues that are reported by GitHub users external to the Azure organization. Community Contribution Community members are working on the issue labels Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@JoseCSantos JoseCSantos JoseCSantos approved these changes

@singankit singankit singankit approved these changes

@ShipraJain01 ShipraJain01 ShipraJain01 approved these changes

Assignees
No one assigned
Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guptha23 @azure-sdk @JoseCSantos @singankit @ShipraJain01 @annatisch