Address API View feedback for RedTeam #40257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses API view feedback for the RedTeam by adding and updating the generated client code for RAISvc operations and models.
- Introduces comprehensive synchronous and asynchronous operation implementations for the RAISvc API.
- Updates models, patch files, and client configuration to align with the latest API view feedback.
- Adds versioning and initialization improvements across both sync and async client modules.
Reviewed Changes
Copilot reviewed 41 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/operations/_operations.py | Generated synchronous operation methods for RAISvc. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/operations/init.py | Module initialization for operations. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/models/*.py | Generated models and customization patch files for RAISvc. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/aio/operations/_operations.py | Generated asynchronous operation methods for RAISvc. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/aio/* | Async client configuration and supporting modules. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/_version.py | Version specification update. |
Files not reviewed (5)
- sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/_serialization.py: Language not supported
- sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/_model_base.py: Language not supported
- sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/_configuration.py: Language not supported
- sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/_client.py: Language not supported
- sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/raiclient/init.py: Language not supported
singankit
approved these changes
Mar 27, 2025
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines