Sync eng/common directory with azure-sdk-tools for PR 10145 #40255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
requested review from
Copilot and
scbedd
and removed request for
scbedd
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with the latest changes from azure-sdk-tools, updating the job matrix generation template.
- Added descriptive comments for the parameters PRMatrixSetting and PRMatrixKey.
- Modified the formatting for the PRMatrixKey parameter definition.
Files not reviewed (1)
- eng/common/scripts/job-matrix/Create-PrJobMatrix.ps1: Language not supported
Comments suppressed due to low confidence (1)
eng/common/pipelines/templates/jobs/generate-job-matrix.yml:53
- The formatting of the 'PRMatrixKey' parameter appears incorrect due to the combined '+-' token. Please change it to '- name: PRMatrixKey' to maintain proper YAML structure.
+- name: PRMatrixKey
4ed04e1 to
045a643
Compare
scbedd
approved these changes
Mar 27, 2025
azure-sdk
force-pushed
the
sync-eng/common-add-key-support-10145
branch
from
045a643 to
716e2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10145 See eng/common workflow