Re-use analyze-weekly templates
#40253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to reduce duplication in pipeline definitions by re-using the analyze‑weekly templates.
- Removed the inline weekly stage definition from the standalone template
- Replaced the duplicated stage logic with a template reference in the standalone pipeline
- Added a conditional inclusion of the analyze‑weekly stage in the archetype‑sdk‑tests pipeline
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/templates/stages/python-analyze-weekly.yml | Minor adjustments to the conditional block for weekly tests |
| eng/pipelines/templates/stages/python-analyze-weekly-standalone.yml | Removed extensive inline stage definition and replaced it with a template reference |
| eng/pipelines/templates/stages/archetype-sdk-tests.yml | Added conditional logic to include the new analyze‑weekly template |
Comments suppressed due to low confidence (2)
eng/pipelines/templates/stages/python-analyze-weekly-standalone.yml:17
- Ensure that the template invocation includes all required parameters from the removed inline stage definition. Double-check that replacing the inline configuration with a template call does not omit any necessary settings.
- template: /eng/pipelines/templates/stages/python-analyze-weekly.yml
eng/pipelines/templates/stages/archetype-sdk-tests.yml:165
- Verify that the added conditional block is correctly indented within the YAML structure to ensure proper parsing of the pipeline definition.
- ${{ if contains(variables['Build.DefinitionName'], 'tests-weekly') }}:
scbedd
commented
Mar 27, 2025
weshaggard
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce duplication by half. FYI @benbp this is in response to your comment on that other PR 👍
EDIT: a run of the new code