Catch exception for missing duration value #40244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingernupur
requested review from
paulshealy1,
achauhan-scc and
jayesh-tanna
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses an issue where a missing or improperly formatted duration value causes logging to fail by wrapping the log call within a try/except block.
- Wraps the total time log statement with a try/except block to catch exceptions due to missing duration values
- Adds an inline comment describing the expected duration format
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_workspace_operations_base.py
Outdated
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kshitij-microsoft
approved these changes
Mar 27, 2025
achauhan-scc
approved these changes
Mar 27, 2025
kshitij-microsoft
pushed a commit
that referenced
this pull request
Mar 27, 2025
* catch exception for missing duration value * Log exception warning * Add util tests * Fix pylint and isort errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines