-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle openapi tools #40238
base: main
Are you sure you want to change the base?
handle openapi tools #40238
Conversation
Thank you for your contribution @stevepon! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for handling OpenAPI tool calls in the evaluation SDK by introducing new conversion logic for openapi-based messages. Key changes include:
- Defining a new constant (_OPENAPI_FUNCTION) for openapi functions.
- Extending the break_tool_call_into_messages function to process openapi tool calls for both message creation and output conversion.
- Adding an early return if the output is None to simplify subsequent processing.
Comments suppressed due to low confidence (2)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_converters/_models.py:183
- For consistency, consider replacing the literal "openapi" with the _OPENAPI_FUNCTION constant defined earlier.
elif tool_call.details.type == "openapi":
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_converters/_models.py:188
- [nitpick] Consider using a consistent access pattern (either dot notation or dictionary indexing) for the 'function' property to improve code readability.
"name": tool_call.details["function"]["name"],
API change check APIView has identified API level changes in this PR and created following API reviews. |
@stevepon please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
@stevepon please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines