Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Sample for Agent Evaluators #40232

Merged
merged 8 commits into from
Mar 26, 2025

Conversation

singankit
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot bot review requested due to automatic review settings March 26, 2025 17:42
@singankit singankit requested a review from a team as a code owner March 26, 2025 17:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates naming conventions for evaluator threshold constants and adjusts sample evaluator notebooks and installation instructions.

  • Updated tests and evaluator code to reference internal constants with an underscore prefix.
  • Modified sample notebooks to use updated tool_call identifier keys, version bumps, and agent naming.
  • Revised installation instructions to include additional dependencies and updated pip command.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/unittests/test_completeness_evaluator.py Updated references to threshold constants.
samples/agent_evaluators/user_functions.py Added an extra location in weather mock data.
samples/agent_evaluators/tool_call_accuracy.ipynb Updated tool call structure and identifiers.
samples/agent_evaluators/intent_resolution.ipynb Updated imports and kernel configuration.
samples/agent_evaluators/instructions.md Changed installation instructions and added dependencies.
samples/agent_evaluators/agent_evaluation.ipynb Adjusted agent name, file handling, and removed unused evaluator cells.
azure/ai/evaluation/_evaluators/_response_completeness/_response_completeness.py Changed constant names to use underscore prefixes.
azure/ai/evaluation/_evaluators/_intent_resolution/_intent_resolution.py Updated constant references for score validation.
Comments suppressed due to low confidence (1)

sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_intent_resolution/_intent_resolution.py:128

  • Consider using a consistent naming convention for the maximum score constant by updating 'IntentResolutionEvaluator.MAX_INTENT_RESOLUTION_SCORE' to 'IntentResolutionEvaluator._MAX_INTENT_RESOLUTION_SCORE' to match the error message and the naming used for the minimum score.
if not check_score_is_valid(score, IntentResolutionEvaluator._MIN_INTENT_RESOLUTION_SCORE, IntentResolutionEvaluator.MAX_INTENT_RESOLUTION_SCORE):

@singankit singankit changed the title Users/singankit/update instructions agent evluators Fixing Sample for Agent Evaluators Mar 26, 2025
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Mar 26, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-evaluation

@w-javed
Copy link
Contributor

w-javed commented Mar 26, 2025

LGTM

@w-javed w-javed merged commit 570f834 into main Mar 26, 2025
19 checks passed
@w-javed w-javed deleted the users/singankit/update_instructions_agent_evluators branch March 26, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants