-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Sample for Agent Evaluators #40232
Fixing Sample for Agent Evaluators #40232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates naming conventions for evaluator threshold constants and adjusts sample evaluator notebooks and installation instructions.
- Updated tests and evaluator code to reference internal constants with an underscore prefix.
- Modified sample notebooks to use updated tool_call identifier keys, version bumps, and agent naming.
- Revised installation instructions to include additional dependencies and updated pip command.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/unittests/test_completeness_evaluator.py | Updated references to threshold constants. |
samples/agent_evaluators/user_functions.py | Added an extra location in weather mock data. |
samples/agent_evaluators/tool_call_accuracy.ipynb | Updated tool call structure and identifiers. |
samples/agent_evaluators/intent_resolution.ipynb | Updated imports and kernel configuration. |
samples/agent_evaluators/instructions.md | Changed installation instructions and added dependencies. |
samples/agent_evaluators/agent_evaluation.ipynb | Adjusted agent name, file handling, and removed unused evaluator cells. |
azure/ai/evaluation/_evaluators/_response_completeness/_response_completeness.py | Changed constant names to use underscore prefixes. |
azure/ai/evaluation/_evaluators/_intent_resolution/_intent_resolution.py | Updated constant references for score validation. |
Comments suppressed due to low confidence (1)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_intent_resolution/_intent_resolution.py:128
- Consider using a consistent naming convention for the maximum score constant by updating 'IntentResolutionEvaluator.MAX_INTENT_RESOLUTION_SCORE' to 'IntentResolutionEvaluator._MAX_INTENT_RESOLUTION_SCORE' to match the error message and the naming used for the minimum score.
if not check_score_is_valid(score, IntentResolutionEvaluator._MIN_INTENT_RESOLUTION_SCORE, IntentResolutionEvaluator.MAX_INTENT_RESOLUTION_SCORE):
API change check APIView has identified API level changes in this PR and created following API reviews. |
LGTM |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines