-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for registry model create/update with system metadata #40064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a new method to handle model create/update operations with system metadata when operating in a registry context. Key changes include:
- Adding new imports required for building and converting create/update requests.
- Updating the create_or_update method to conditionally use the new system metadata operation based on the presence of continuation tokens.
- Adding a new private helper method (_begin_create_or_update_model_with_system_metadata) to handle the create/update process using system metadata.
Comments suppressed due to low confidence (1)
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_model_operations.py:353
- [nitpick] Consider defining a named constant for the accepted async status code (202) to improve readability and maintainability.
if response.status_code not in [202]:
API change check APIView has identified API level changes in this PR and created following API reviews. |
95f5418
to
7f22b4e
Compare
1fca117
to
656ce92
Compare
3de05cb
to
41b5b4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Http interactions are happening inside rest client layer, please follow the same pattern.
…re#40064) * Add method for registry model create/update with system metadata * add e2e test * fix test * fix test recording * fix test recording * fix test recording * fix tests * fix mypy * run black * fix pylint * move request method * refactor code * fix tests * fix compiling * update recording * fix black
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines