-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample code for Morningstar agent #40005
Sample code for Morningstar agent #40005
Conversation
Thank you for your contribution @nik1097! We will review the pull request and get back to you soon. |
@microsoft-github-policy-service agree company="Morningstar" |
API change check APIView has identified API level changes in this PR and created following API reviews. |
Hi @nik1097 - thank you so much for the PR!
@dargilco - would you be able to review this sample when you get a chance? |
d23d75d
to
8ee6617
Compare
sdk/ai/azure-ai-projects/samples/agents/sample_agents_morningstar.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/agents/sample_agents_morningstar.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/agents/sample_agents_morningstar.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/agents/sample_agents_morningstar.py
Outdated
Show resolved
Hide resolved
692e902
to
2079230
Compare
Hey @jhakulin @annatisch I've addressed the comments by updating my code. Please let me know if this looks good to go. Thank you for your time! |
sdk/ai/azure-ai-projects/samples/agents/sample_agents_openapi_morningstar.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/agents/sample_agents_openapi_morningstar.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/agents/sample_agents_openapi_morningstar.py
Show resolved
Hide resolved
@nik1097 thank you for this sample! I love it. Our working feature branch for the next release (out soon) is |
526d93f
to
b0aa7e1
Compare
@dargilco thank you so much for your comments, I've addressed them and tested my code. I've also pointed the PR to the mentioned branch. |
FYI I think the function create_and_process_run has a bug. Am I on the wrong version here? |
@nik1097 regarding "When I run it locally it expects a field called assistant_id and during the CI check it says it expects agent_id", this was already fixed in this feature branch. You can verify the fix by running "pip install -e ." in the folder Update: Oh, I see there are errors in the CI pipeline. Let me take a look at this. More updates: I merged the PR so I can run our quality gate tools locally and better look at the pipeline failure. Thank you @nik1097! |
fa9127e
into
Azure:feature/azure-ai-projects-beta8
@nik1097 please provide the file |
@dargilco |
Description
This PR includes steps for creating a custom Morningstar Agent.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines