Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample code for Morningstar agent #40005

Conversation

nik1097
Copy link

@nik1097 nik1097 commented Mar 10, 2025

Description

This PR includes steps for creating a custom Morningstar Agent.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added AI Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 10, 2025
Copy link

Thank you for your contribution @nik1097! We will review the pull request and get back to you soon.

@nik1097
Copy link
Author

nik1097 commented Mar 10, 2025

@microsoft-github-policy-service agree company="Morningstar"

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 10, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-projects

@annatisch
Copy link
Member

annatisch commented Mar 19, 2025

Hi @nik1097 - thank you so much for the PR!
Would you be able to address this typing error so that we could get CI green?

samples/agents/sample_agents_morningstar.py:142: error: Missing named argument "agent_id" for "create_and_process_run" of "AgentsOperations"  [call-arg]

@dargilco - would you be able to review this sample when you get a chance?

@nik1097 nik1097 force-pushed the morninstar-agent-sample branch from d23d75d to 8ee6617 Compare March 20, 2025 19:37
@nik1097 nik1097 force-pushed the morninstar-agent-sample branch from 692e902 to 2079230 Compare March 25, 2025 15:42
@nik1097
Copy link
Author

nik1097 commented Mar 25, 2025

Hey @jhakulin @annatisch I've addressed the comments by updating my code. Please let me know if this looks good to go. Thank you for your time!

@dargilco
Copy link
Member

@nik1097 thank you for this sample! I love it. Our working feature branch for the next release (out soon) is feature/azure-ai-projects-beta8. Do you mind targeting your PR to this feature branch? We'll give you credit in the CHANGELOG.md file of this release.

@nik1097 nik1097 force-pushed the morninstar-agent-sample branch from 526d93f to b0aa7e1 Compare March 27, 2025 19:30
@nik1097 nik1097 changed the base branch from main to feature/azure-ai-projects-beta8 March 27, 2025 19:30
@nik1097
Copy link
Author

nik1097 commented Mar 27, 2025

@dargilco thank you so much for your comments, I've addressed them and tested my code. I've also pointed the PR to the mentioned branch.

@nik1097
Copy link
Author

nik1097 commented Mar 27, 2025

FYI I think the function create_and_process_run has a bug.
When I run it locally it expects a field called assistant_id and during the CI check it says it expects agent_id.

Am I on the wrong version here?

@annatisch @dargilco

@dargilco
Copy link
Member

dargilco commented Mar 27, 2025

@nik1097 regarding "When I run it locally it expects a field called assistant_id and during the CI check it says it expects agent_id", this was already fixed in this feature branch. You can verify the fix by running "pip install -e ." in the folder \sdk\ai\azure-ai-projects, which will install the package from the current sources instead of the public package. Please let me know if that worked for you.

Update: Oh, I see there are errors in the CI pipeline. Let me take a look at this.

More updates: I merged the PR so I can run our quality gate tools locally and better look at the pipeline failure. Thank you @nik1097!

@dargilco dargilco merged commit fa9127e into Azure:feature/azure-ai-projects-beta8 Mar 27, 2025
18 of 21 checks passed
@dargilco
Copy link
Member

dargilco commented Mar 27, 2025

@nik1097 please provide the file iep_openapi.json or give me instructions where to get it. Once that's provided, we can add this sample to the Main branch.

@nik1097
Copy link
Author

nik1097 commented Mar 28, 2025

@dargilco
iep_openapi.json
I have attached the openapi specs here, I've shared the account credentials with Linda Li from your team. You will need an auth token to talk to this endpoint.
We are working on having this on a public website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants