Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SipRouting trunk setting sdk changes. #39858

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

SipRouting trunk setting sdk changes. #39858

wants to merge 10 commits into from

Conversation

v-pivamshi
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-phonenumbers

@v-pivamshi
Copy link
Contributor Author

User Story 3920786: SDK Implementation: Python

  1. Generated swagger.
  2. Added api changes.

@v-dharmarajv v-dharmarajv marked this pull request as ready for review March 17, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiriburant jiriburant jiriburant left review comments

@Arazan Arazan Awaiting requested review from Arazan Arazan is a code owner

@whisper6284 whisper6284 Awaiting requested review from whisper6284 whisper6284 is a code owner

@danielortega-msft danielortega-msft Awaiting requested review from danielortega-msft danielortega-msft is a code owner

@sofiar-msft sofiar-msft Awaiting requested review from sofiar-msft sofiar-msft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Communication - Phone Numbers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-pivamshi @azure-sdk @jiriburant