[ServiceBus/EventHub] unique message/correlation ID for mgmt ops #39516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swathipil
changed the title
|
API change check API changes are not detected in this pull request. |
l0lawrence
reviewed
Feb 3, 2025
l0lawrence
reviewed
Feb 3, 2025
kashifkhan
reviewed
Feb 3, 2025
sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_management_link_async.py
Show resolved
Hide resolved
1 task
|
/azp run python - servicebus - tests |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
l0lawrence
reviewed
Feb 11, 2025
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kashifkhan
approved these changes
Feb 11, 2025
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
…re#39516) * [SB] Msg IDs on mgmt/cbs ops should be unique * copy over sb pyamqp to eh * add tests * remove disable local auth for tests ci run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #39515
Incrementing next_message_id for mgmt ops as we do currently results in the same message ID (0) being used across all messages when renewing locks and other ops such as CBS. This becomes an issue when trying to correlate messages to renew locks/etc., since theIDs are not unique.
Updating message/correlation IDs to unique values so that we don't run into this issue.
Also copied over pyamqp changes from SB to EH, to make sure these are sync'ed.
TODO: