Enable ExcludePaths in the pullrequest pipeline#39231
Merged
JimSuplizio merged 4 commits intoAzure:mainfrom Jan 16, 2025
Merged
Enable ExcludePaths in the pullrequest pipeline#39231JimSuplizio merged 4 commits intoAzure:mainfrom
JimSuplizio merged 4 commits intoAzure:mainfrom
Conversation
JimSuplizio
requested review from
a team,
annatisch,
benbp,
lmazuel,
scbedd and
weshaggard
as code owners
scbedd
approved these changes
Jan 16, 2025
Member
scbedd
left a comment
scbedd
left a comment
There was a problem hiding this comment.
Looks good pending your commit/reversion tests. Thanks @JimSuplizio this is definitely solving a problem I didn't have an answer for.
Collaborator
|
API change check API changes are not detected in this pull request. |
benbp
approved these changes
Jan 16, 2025
allenkim0129
pushed a commit
to allenkim0129/azure-sdk-for-python
that referenced
this pull request
Jan 27, 2025
* Enable ExcludePaths in the pullrequest pipeline * Temporary commit for testing, changes will be reverted before merge * Reverting the testing changes to cosmos and template's MD files * Really revert this time. VS Code trimming spaces caused it to not be reverted
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* Enable ExcludePaths in the pullrequest pipeline * Temporary commit for testing, changes will be reverted before merge * Reverting the testing changes to cosmos and template's MD files * Really revert this time. VS Code trimming spaces caused it to not be reverted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request pipeline would create PackageInfo files for everything in the PR diff and this would result in things running as part of the PR pipeline that are excluded via the PR trigger. For Python this is only sdk/cosmos right now. This PR just plumbs through the ExcludePaths.
This is ready for review but, sanity's sake, I'm going to add, then remove, a commit that changes a file in Cosmos and one in Template to re-verify that, with these changes the azure-cosmos packageInfo isn't created and no tests are run. I say re-verify because I had a PR on Tuesday that tested these changes and this is just sanity since some of the changes were eng/common.
Runs with the Comos and Template change commit, the PR pipeline correctly shows the targeted packages do not include azure-cosmos, as expected.