Getting model config from connection to be used with evalutors #39171
Conversation
* Fixed and chain stream * Roll back to keep until_done() for the main stream. * added tests * fixed CI * added integrated tests * fixed lint * fixed lint and test * ghope to fix doc gen * fix test and doc gen * enable tests for streaming
* multiagent sample * config file, team leader configurability * multiagent folder * review changes * fixes * fixes * fix --------- Co-authored-by: Marko Hietala <markhiet@microsoft.com>
* handle incompleted events * Fixed CI and add chagne log
singankit
requested review from
luigiw,
needuv,
achauhan-scc,
kingernupur,
paulshealy1,
dargilco,
jhakulin and
jayesh-tanna
as code owners
|
Please target this PR toward the feature branch |
|
Please update the "Bug fixes" section in CHANGELOG.md with a description of the fix. |
singankit
changed the base branch from
main
to
feature/azure-ai-projects-beta5
singankit
requested review from
mccoyp,
catalinaperalta,
kristapratico,
iscai-msft,
scbedd,
lmazuel,
xiangyan99,
a team,
weshaggard and
benbp
as code owners
* Fixes mypy type errors. * Fixed mypy errors * Fixed pylint annotation errors --------- Co-authored-by: Dina Saparbaeva <dsaparbaeva@microsoft.com>
* Fixed samples * update date
* Update code_report.py * Fix AttributeError by using `__all__` for operations
* update typespec-python 0.38.0 * update package.json
* Update sample_evaluations.py * Update sample_evaluations.py * Update sample_evaluations_async.py * Replace HateUnfairnessEvaluator with ViolenceEvaluator
* Fix urls * update
* Fix urls * update
…github.com/Azure/azure-sdk-for-python into users/singankit/connection_to_model_config
singankit
changed the base branch from
feature/azure-ai-projects-beta5
to
main
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| @@ -238,7 +238,7 @@ def __init__( | |||
| self.key = connection.properties.credentials.key # type: ignore | |||
| self.token_credential = token_credential | |||
|
|
|||
| def to_evaluator_model_config(self, deployment_name, api_version) -> Dict[str, str]: | |||
| def to_evaluator_model_config(self, deployment_name, api_version, *, include_credentials=False) -> Dict[str, str]: | |||
There was a problem hiding this comment.
Is it possible for us to check the connection type, and if its key-based, automatically add the include_credentials=True to the underlying call?
That removes some complexity for the end user, the code doesn't need to change if the connection type changes.
There was a problem hiding this comment.
For local usage that will work perfectly. But for remote evals it could lead to secret unintentionally getting exposed hence added this param explicitly. Same is done for connections too.
|
Hi @singankit. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
Hi @singankit. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines