-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move KV Keys to pyproject.toml #39100
base: main
Are you sure you want to change the base?
Conversation
… packages can flow through
…the rest of the failures
…as removing the assumed setup.py in favor of just using the package directory
…o the set of dependencies that are installed (so that installing pure pyproject.toml packages does not fail). this repairs the depends tox environment
Just going to edit this comment here to highlight discovered issues that aren't readily available in the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Adding a build folder to azure-keyvault-keys and building the wheel from this results in a wheel with a build folder.
Ok I just merged main! Here's hoping everything is green! From there I will do one last sanity check of |
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is green now! I'm approving for the various tools pipeline changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Key Vault Keys package metadata from setup.py to pyproject.toml and updates the azure-sdk-tools code to support this change. The key changes include creating a new pyproject.toml for azure-keyvault-keys, adding a new CLI entrypoint build_package in the CI tools, and updating various file paths and logics to handle both setup.py and pyproject.toml formats.
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
sdk/keyvault/azure-keyvault-keys/pyproject.toml | Added a complete pyproject.toml configuration for the package. |
tools/azure-sdk-tools/ci_tools/build.py | Introduced build_package and adjusted package-building logic to forward wheel/sdist flags. |
eng/tox/verify_sdist.py | Modified glob pattern to search for tar.gz files in nested folders. |
eng/tox/install_depend_packages.py | Changed argument naming from setup_py_path to package_directory and updated related logic. |
tools/azure-sdk-tools/setup.py | Removed the setup.py for the Key Vault Keys package in favor of pyproject.toml. |
eng/scripts/get_package_properties.py | Adjusted search condition to detect either setup.py or pyproject.toml. |
Other CI and parsing files | Minor updates to logging messages and function argument usage to accommodate the new format. |
Files not reviewed (3)
- eng/ci_tools.txt: Language not supported
- eng/test_tools.txt: Language not supported
- eng/tox/tox.ini: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.