Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move KV Keys to pyproject.toml #39100

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Move KV Keys to pyproject.toml #39100

wants to merge 19 commits into from

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Jan 9, 2025

No description provided.

@lmazuel lmazuel requested a review from scbedd January 9, 2025 21:43
@lmazuel lmazuel requested a review from mccoyp as a code owner January 9, 2025 21:43
scbedd added 2 commits January 9, 2025 15:49
…as removing the assumed setup.py in favor of just using the package directory
…o the set of dependencies that are installed (so that installing pure pyproject.toml packages does not fail). this repairs the depends tox environment
@scbedd
Copy link
Member

scbedd commented Jan 10, 2025

Just going to edit this comment here to highlight discovered issues that aren't readily available in the pullrequest pipeline.

  • Fix mindependency/latestdependency crashes
  • Fix depends crash
  • Add build to default dependencies for all of tox (so that create_package when invoked for local packages won't crash on pure pyproject.toml)
  • Enable nightly alpha update for requirements (if the azure requirement doesn't exist on pypi, we update it with the alpha suffix so that the nightly scheduled internal feed builds will match the latest alpha version)
    • Our requirement updater isn't tightly bound to setup.py! Wonder of wonders I don't need to make any changes!

Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Adding a build folder to azure-keyvault-keys and building the wheel from this results in a wheel with a build folder.

@scbedd
Copy link
Member

scbedd commented Mar 4, 2025

Ok I just merged main! Here's hoping everything is green!

From there I will do one last sanity check of internal keyvault release build, but I think we should be g2g!

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is green now! I'm approving for the various tools pipeline changes.

@scbedd scbedd requested a review from a team as a code owner March 18, 2025 22:20
@lmazuel lmazuel requested a review from Copilot March 18, 2025 23:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Key Vault Keys package metadata from setup.py to pyproject.toml and updates the azure-sdk-tools code to support this change. The key changes include creating a new pyproject.toml for azure-keyvault-keys, adding a new CLI entrypoint build_package in the CI tools, and updating various file paths and logics to handle both setup.py and pyproject.toml formats.

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/keyvault/azure-keyvault-keys/pyproject.toml Added a complete pyproject.toml configuration for the package.
tools/azure-sdk-tools/ci_tools/build.py Introduced build_package and adjusted package-building logic to forward wheel/sdist flags.
eng/tox/verify_sdist.py Modified glob pattern to search for tar.gz files in nested folders.
eng/tox/install_depend_packages.py Changed argument naming from setup_py_path to package_directory and updated related logic.
tools/azure-sdk-tools/setup.py Removed the setup.py for the Key Vault Keys package in favor of pyproject.toml.
eng/scripts/get_package_properties.py Adjusted search condition to detect either setup.py or pyproject.toml.
Other CI and parsing files Minor updates to logging messages and function argument usage to accommodate the new format.
Files not reviewed (3)
  • eng/ci_tools.txt: Language not supported
  • eng/test_tools.txt: Language not supported
  • eng/tox/tox.ini: Language not supported

lmazuel and others added 2 commits March 19, 2025 16:49
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants