[Identity] Use full path for CLI executables #38606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2024
|
API change check API changes are not detected in this pull request. |
pvaneck
force-pushed
the
identity-cli-path
branch
from
c896269 to
780756c
Compare
pvaneck
requested review from
maorleger,
billwert,
g2vinay,
ahsonkhan,
chlowell and
mpodwysocki
|
Hi @pvaneck. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
Also, adjustments were made to pass in subprocess arguments as a list. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-cli-path
branch
from
780756c to
3106f50
Compare
github-actions
bot
removed
the
no-recent-activity
xiangyan99
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
shutil.whichis always run to verify the existence of theazandazdexecutables, and it gives the full path of the executable, let's just call the executable path directly forAzureCliCredentialandAzureDeveloperCliCredential.Also, adjustments were made to pass in subprocess arguments as a list which is the preferred (more secure) way of passing commands/arguments to subprocesses instead of going through the shell.