Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[communication]-[sms]-Setting live tests to false temporarily #38096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[communication]-[sms]-Setting live tests to false temporarily #38096

wants to merge 1 commit into from

Conversation

dinazavyr
Copy link
Member

@dinazavyr dinazavyr commented Oct 25, 2024 •
edited
Loading

Description

Setting live tests to false temporarily, until DefaultAzureCredential is fixed in managed identity tests..

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfeitosa-msft gfeitosa-msft Awaiting requested review from gfeitosa-msft gfeitosa-msft is a code owner

@besh2014 besh2014 Awaiting requested review from besh2014 besh2014 is a code owner

@phermanov-msft phermanov-msft Awaiting requested review from phermanov-msft phermanov-msft is a code owner

@ilyapaliakou-msft ilyapaliakou-msft Awaiting requested review from ilyapaliakou-msft ilyapaliakou-msft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Communication - SMS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinazavyr @azure-sdk