Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erbek/fix nxdomain error #37837

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Erbek/fix nxdomain error #37837

wants to merge 2 commits into from

Conversation

erbek
Copy link

@erbek erbek commented Oct 10, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added App Configuration Provider Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Oct 10, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @erbek! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@annatisch
Copy link
Member

Adding @mrm9084
Fix for issue #37835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertofori albertofori Awaiting requested review from albertofori albertofori is a code owner

@avanigupta avanigupta Awaiting requested review from avanigupta avanigupta is a code owner

@mrm9084 mrm9084 Awaiting requested review from mrm9084 mrm9084 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
App Configuration Provider Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erbek @azure-sdk @annatisch