Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Evaluation] Rename parameter name project_scope to azure_ai_project #37409

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

ninghu
Copy link
Contributor

@ninghu ninghu commented Sep 15, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [] The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ninghu ninghu requested a review from a team as a code owner September 15, 2024 17:42
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Sep 15, 2024
@ninghu ninghu enabled auto-merge (squash) September 16, 2024 19:38
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-evaluation

@ninghu ninghu merged commit 9a8f379 into main Sep 16, 2024
19 checks passed
@ninghu ninghu deleted the ninhu/project_scope branch September 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants