Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the non adversarial simulator #37350

Merged
merged 23 commits into from
Sep 20, 2024

Conversation

nagkumar91
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nagkumar91 nagkumar91 requested a review from a team as a code owner September 12, 2024 20:01
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Sep 12, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-evaluation

Copy link
Member

@changliu2 changliu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass on task_simulate

Copy link
Member

@changliu2 changliu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved issues after improving docstring and cut down output paths to simplify.

Copy link
Member

@changliu2 changliu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved issues by improving docstring/warning messages and cutting down possible output paths to simplify.

@nagkumar91 nagkumar91 merged commit a9233f4 into Azure:main Sep 20, 2024
19 checks passed
@nagkumar91 nagkumar91 deleted the feature/query_response branch September 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants