Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #37300

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix broken links #37300

merged 1 commit into from
Sep 12, 2024

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Sep 11, 2024

Description

This fixes two broken links for azure-purview-sharing -- a PyPI aka.ms link appears to have been removed, and a broken ref docs link is replaced with an aka.ms link to the same docs that's used elsewhere.

One broken link came from the long-deprecated core/azure package: a migration guide from 2016 that no longer exists in the repo's wiki. Given the fact that the package is no longer used and the guide was almost a decade old, I removed the link and included a note to mention the docs being dropped.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@mccoyp
Copy link
Member Author

mccoyp commented Sep 12, 2024

/check-enforcer override

@mccoyp mccoyp merged commit 72ed2a5 into Azure:main Sep 12, 2024
299 of 301 checks passed
@mccoyp mccoyp deleted the broken-links branch September 12, 2024 17:30
@weshaggard
Copy link
Member

@mccoyp I assume the failing purview pipeline will be addressed separately before their next release?

@mccoyp
Copy link
Member Author

mccoyp commented Sep 12, 2024

@weshaggard It looks like they'll need to address some things, yes. The Purview CI pipeline has been failing since it was apparently re-enabled in early September, unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants