Update to Analyze job condition
#37212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re is that we need to download packages_extended from the build_extended stage, so having it set as succededOrFailed() when buildextended DOES fail, means that we can't get the artifact anyway! may as well remove the dependency
catalinaperalta
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@catalinaperalta reported an issue with
Analyzeunexpectedly failing due to inability to find the relevant artifact. The source turned out to be Build_Extended failing.The reason behind Build_Extended failing doesn't actually matter. What matters is that due to the job condition governing
Analyze, we would runAnalyzeeven ifBuild_Extended(its sole dependency) failed! IfBuild_Extendedfails, then the artifactpackages_extended, whichAnalyzeREQUIRES to be present, won't exist named aspackages_extended! If the artifact doesn't exist, it can't be downloaded inAnalyze, and we get failures that complain about being unable to locate the wheel.Simply change the condition to
succeeded(), which will delay the job run untilBuild_Extendedpasses.