Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Validate identity config for MICredential #36950

Merged
merged 2 commits into from
Aug 21, 2024
Merged

[Identity] Validate identity config for MICredential #36950

merged 2 commits into from
Aug 21, 2024

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Aug 20, 2024

@pvaneck
[Identity] Validate identity config for MICredential
c0c932a 
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck force-pushed the identity-object-id-validate branch from 1b0be12 to c0c932a Compare August 20, 2024 01:32
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

@pvaneck pvaneck marked this pull request as ready for review August 20, 2024 17:42
@pvaneck pvaneck requested review from xiangyan99 and a team as code owners August 20, 2024 17:42
@pvaneck
updates based on review
055ce13 
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck merged commit 513989e into Azure:main Aug 21, 2024
20 checks passed
@pvaneck pvaneck deleted the identity-object-id-validate branch August 21, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvaneck @azure-sdk @xiangyan99