Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: None was being appended to output path for batch-endpoint invoke command and wasn't picking up the override output path #36089

Merged
merged 29 commits into from
Jun 17, 2024
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6a57cea
Reverting models to make sure calls to the simulator work
nagkumar91 Mar 7, 2024
dd01ecf
merge
nagkumar91 Mar 7, 2024
8cea9c3
quotes
nagkumar91 Mar 7, 2024
bea237e
Spellcheck fixes
nagkumar91 Mar 7, 2024
45073cc
ignore the models for doc generation
nagkumar91 Mar 7, 2024
08af5b3
Fixed the quotes on f strings
nagkumar91 Mar 7, 2024
7584cc9
pylint skip file
nagkumar91 Mar 7, 2024
e10fe6f
Merge branch 'Azure:main' into main
nagkumar91 Mar 7, 2024
304d506
Merge branch 'Azure:main' into main
nagkumar91 Mar 11, 2024
d727177
Support for summarization
nagkumar91 Mar 11, 2024
8b895ee
Adding a limit of 2 conversation turns for all but conversation simul…
nagkumar91 Mar 11, 2024
92d6d8e
exclude synthetic from mypy
nagkumar91 Mar 11, 2024
4742b04
Another lint fix
nagkumar91 Mar 11, 2024
975b0b3
Skip the file causing linting issues
nagkumar91 Mar 12, 2024
a00871f
Merge branch 'Azure:main' into main
nagkumar91 Mar 12, 2024
6bf1de0
Bugfix on output to json_qa_lines and empty response from callbacks
nagkumar91 Mar 13, 2024
5a974ce
Merge branch 'main' into main
nagkumar91 Mar 13, 2024
3f9c000
Skip pylint
nagkumar91 Mar 13, 2024
5ab6ab2
Merge branch 'main' of https://github.com/nagkumar91/azure-sdk-for-py…
nagkumar91 Mar 13, 2024
0c76fb0
Add if/else on message to eval json util
nagkumar91 Mar 14, 2024
fad8599
Merge branch 'Azure:main' into main
nagkumar91 Mar 21, 2024
a6d8d0f
Merge branch 'main' of https://github.com/nagkumar91/azure-sdk-for-py…
nagkumar91 Mar 25, 2024
a1e9c9d
adding max_simulation_results for sync call
nagkumar91 Mar 25, 2024
10ba426
Merge branch 'main' of https://github.com/nagkumar91/azure-sdk-for-py…
nagkumar91 Mar 25, 2024
3634d7c
Merge branch 'main' of https://github.com/nagkumar91/azure-sdk-for-py…
nagkumar91 Apr 1, 2024
1cbc55c
Merge branch 'main' of https://github.com/nagkumar91/azure-sdk-for-py…
nagkumar91 May 23, 2024
ac39d75
Merge branch 'main' of https://github.com/nagkumar91/azure-sdk-for-py…
nagkumar91 Jun 12, 2024
85e91bf
Merge branch 'main' of https://github.com/nagkumar91/azure-sdk-for-py…
nagkumar91 Jun 13, 2024
503634d
Bugfix: None was being added to the end of the output path
nagkumar91 Jun 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions sdk/ml/azure-ai-ml/azure/ai/ml/_utils/_endpoint_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# ---------------------------------------------------------

# pylint: disable=protected-access
# pylint: disable=protected-access,E0401,E0611

import ast
import concurrent.futures
Expand Down Expand Up @@ -218,7 +218,12 @@ def validate_scoring_script(deployment):


def convert_v1_dataset_to_v2(output_data_set: DataVersion, file_name: str) -> Dict[str, Any]:
v2_dataset = UriFileJobOutput(
uri=f"azureml://datastores/{output_data_set.datastore_id}/paths/{output_data_set.path}/{file_name}"
).serialize()
if file_name:
v2_dataset = UriFileJobOutput(
uri=f"azureml://datastores/{output_data_set.datastore_id}/paths/{output_data_set.path}/{file_name}"
).serialize()
else:
v2_dataset = UriFileJobOutput(
nagkumar91 marked this conversation as resolved.
Show resolved Hide resolved
uri=f"azureml://datastores/{output_data_set.datastore_id}/paths/{output_data_set.path}"
).serialize()
return {"output_name": v2_dataset}