Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text Translation] Add support for AAD authentication #34883

Merged
merged 12 commits into from
Mar 25, 2024
Merged

[Text Translation] Add support for AAD authentication #34883

merged 12 commits into from
Mar 25, 2024

Conversation

MikeyMCZ
Copy link
Member

Description

Add support for AAD authentication for global Text Translation Endpoint which requires two special headers:

  • Ocp-Apim-ResourceId
  • Ocp-Apim-Subscription-Region

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-translation-text

MikeyMCZ and others added 4 commits March 22, 2024 16:25
@MikeyMCZ @catalinaperalta
Update sdk/translation/azure-ai-translation-text/azure/ai/translation…
7575d16 
…/text/_patch.py

Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
@MikeyMCZ @catalinaperalta
Update sdk/translation/azure-ai-translation-text/azure/ai/translation…
850ab25 
…/text/_patch.py

Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
@MikeyMCZ @catalinaperalta
Update sdk/translation/azure-ai-translation-text/azure/ai/translation…
f5995c6 
…/text/_patch.py

Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
Fix PR comments
710803a
catalinaperalta
catalinaperalta approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure to review this design with architects.

sdk/translation/azure-ai-translation-text/azure/ai/translation/text/_patch.py Outdated Show resolved Hide resolved
sdk/translation/azure-ai-translation-text/azure/ai/translation/text/aio/_patch.py Outdated Show resolved Hide resolved
MikeyMCZ and others added 3 commits March 22, 2024 16:39
@MikeyMCZ @catalinaperalta
Update sdk/translation/azure-ai-translation-text/azure/ai/translation…
d84ee4c 
…/text/_patch.py

Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
@MikeyMCZ @catalinaperalta
Update sdk/translation/azure-ai-translation-text/azure/ai/translation…
360fe33 
…/text/aio/_patch.py

Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
fix types
d54df4a
MikeyMCZ and others added 2 commits March 22, 2024 17:47
@MikeyMCZ @catalinaperalta
Update sdk/translation/azure-ai-translation-text/azure/ai/translation…
4f75659 
…/text/_patch.py

Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
Fix build
4f44ccc
@catalinaperalta catalinaperalta merged commit ebe2d01 into Azure:main Mar 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta approved these changes

@xiangyan99 xiangyan99 xiangyan99 left review comments

@kristapratico kristapratico Awaiting requested review from kristapratico kristapratico is a code owner

Assignees
No one assigned
Labels
Cognitive - Translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeyMCZ @azure-sdk @catalinaperalta @xiangyan99