Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33601: Fix Sphinx error for azure-maps-geolocation #34875

Merged

Conversation

Lakicar95
Copy link
Member

@Lakicar95 Lakicar95 commented Mar 21, 2024

Description

Fix Sphinx errors related to formatting, styling and adopting anonymous links in docstrings. After introducing these changes, we are able to set strict_sphinx to true in pyproject.tom - which enforces strict checking during the Sphinx documentation build process.

Fixes: #33601

[Testing Guidelines]

`../azure-maps-geolocation>pip install "tox<5"

../azure-maps-geolocation>tox run -e strict-sphinx -c ../../../eng/tox/tox.ini --root .`

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps labels Mar 21, 2024
Copy link

Thank you for your contribution @Lakicar95! We will review the pull request and get back to you soon.

@Lakicar95 Lakicar95 marked this pull request as ready for review March 22, 2024 16:13
@kristapratico kristapratico self-requested a review March 22, 2024 16:48
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lakicar95 Thanks for the contribution here as well! Changes look great, going to approve/merge. :)

@kristapratico
Copy link
Member

/check-enforcer override

@kristapratico kristapratico merged commit cab510b into Azure:main Mar 22, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-maps-geolocation needs docstring updates for sphinx
2 participants