Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename use_operating_system_account to use_default_broker_account #34833

Merged
merged 2 commits into from
Mar 19, 2024
Merged

rename use_operating_system_account to use_default_broker_account #34833

merged 2 commits into from
Mar 19, 2024

Conversation

xiangyan99
Copy link
Member

No description provided.

@xiangyan99 xiangyan99 marked this pull request as ready for review March 19, 2024 17:41
@xiangyan99 xiangyan99 requested review from pvaneck and a team as code owners March 19, 2024 17:41
pvaneck
pvaneck approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording suggestion for readme.

sdk/identity/azure-identity-broker/README.md Outdated Show resolved Hide resolved
@xiangyan99 @pvaneck
Update sdk/identity/azure-identity-broker/README.md
0d96e3f 
Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
@xiangyan99 xiangyan99 merged commit 9ea120e into main Mar 19, 2024
18 checks passed
@xiangyan99 xiangyan99 deleted the renaming_use_operating_system_account branch March 19, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvaneck pvaneck pvaneck approved these changes

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangyan99 @pvaneck