Remaining livetest matrices, ci.yml uses image.yml variables
#34727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
weshaggard,
benbp,
kushagraThapar,
simorenoh,
xinlian12,
annatisch,
bambriz,
mccoyp,
miguhern,
whisper6284,
RoyHerrod,
danielav7,
jalauzon-msft,
vincenttran-msft,
pvaneck,
xiangyan99 and
a team
as code owners
scbedd
requested review from
maorleger,
billwert,
ahsonkhan,
KarishmaGhiya and
schaabs
github-actions
bot
added
Azure.Identity
Communication - Phone Numbers
Cosmos
KeyVault
Storage
|
API change check API changes are not detected in this pull request. |
jalauzon-msft
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Approving for Storage but still see some failures in the sample pipeline build.
Absolutely. My second commit 1a032bc definitely takes care of this error. Needed to explicitly use the new image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proving Build.
Checks out. Merging as soon as CI passes.