Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify built-in chat eval flow: #34511

Merged
merged 7 commits into from
Mar 19, 2024
Merged

modify built-in chat eval flow: #34511

merged 7 commits into from
Mar 19, 2024

Conversation

qusongms
Copy link
Contributor

  • modify rai service request format
  • fix aggregation logic
  • add input validation for rai service

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [x ] The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x ] Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@qusongms
modify built-in chat eval flow:
e557744 
* modify rai service request format
* fix aggregation logic
* add input validation for rai service
@github-actions github-actions bot added AI Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Feb 28, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @qusongms! We will review the pull request and get back to you soon.

@singankit singankit merged commit 53ba5aa into Azure:main Mar 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagkumar91 nagkumar91 nagkumar91 approved these changes

@luigiw luigiw Awaiting requested review from luigiw luigiw is a code owner

@needuv needuv Awaiting requested review from needuv needuv is a code owner

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit singankit is a code owner

Assignees
No one assigned
Labels
AI Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qusongms @nagkumar91 @singankit