Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppConfig] Support monitor page changes by page etag #34346

Merged
merged 24 commits into from
Mar 15, 2024
Merged

[AppConfig] Support monitor page changes by page etag #34346

merged 24 commits into from
Mar 15, 2024

Conversation

YalinLi0312
Copy link
Member

@YalinLi0312 YalinLi0312 commented Feb 16, 2024 •
edited
Loading

This PR includes:

  • Enable to monitor page changes via send_request()
  • Enable to get page_etag which lives in response header through custom iterator.

@YalinLi0312 YalinLi0312 added the App Configuration Azure.ApplicationModel.Configuration label Feb 16, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-appconfiguration

@YalinLi0312 YalinLi0312 marked this pull request as ready for review March 7, 2024 02:48
@YalinLi0312 YalinLi0312 merged commit 9c4e540 into Azure:main Mar 15, 2024
17 checks passed
@YalinLi0312 YalinLi0312 deleted the yall-appconfig-etag branch March 15, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@johanste johanste johanste left review comments

@annatisch annatisch Awaiting requested review from annatisch

@jsquire jsquire Awaiting requested review from jsquire

@kinelski kinelski Awaiting requested review from kinelski

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@mssfang mssfang Awaiting requested review from mssfang

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YalinLi0312 @azure-sdk @annatisch @xiangyan99 @johanste