Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Add samples and update README #34107

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Conversation

YalinLi0312
Copy link
Member

@YalinLi0312 YalinLi0312 commented Feb 2, 2024

This PR includes:

  • New samples for how to convert AnalyzeResult to a JSON serializable dict, it's asked in this customer issue.
  • New samples for analyzing document as base64 source, it's asked in this customer issue.
    Update: we have renamed base64_source to bytes_source and added samples sample_analyze_invoices_from_bytes_source.py and sample_analyze_invoices_from_bytes_source_async.py. So removed base64 samples after first round review.
  • Disclaim available regions for API 2024-02-29-preview, it's asked in this customer issue.
  • Added links for some DI docs which were not available when shipping first release.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR isnt changing anything related to the base64->bytes_source change mentioned in the description. The samples added lgtm!

@YalinLi0312
Copy link
Member Author

Looks like this PR isnt changing anything related to the base64->bytes_source change mentioned in the description. The samples added lgtm!

The base64 rename is already merged in another PR, so I reverted any related changes here. Thanks for your review!

@YalinLi0312 YalinLi0312 merged commit 608d1dc into Azure:main Mar 29, 2024
17 checks passed
@YalinLi0312 YalinLi0312 deleted the yall-di-samples branch March 29, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants