[Storage] [Typing] [Blob] Misc files (_serialize.py, _deserialize.py, _download.py)
#33613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
requested review from
annatisch and
jalauzon-msft
as code owners
|
API change check API changes are not detected in this pull request. |
vincenttran-msft
changed the title
_serialize.py)_serialize.py, _deserialize.py)
vincenttran-msft
changed the title
_serialize.py, _deserialize.py)_serialize.py, _deserialize.py, _download.py)
vincenttran-msft
changed the title
_serialize.py, _deserialize.py, _download.py)_serialize.py, _deserialize.py, _download.py)
sdk/storage/azure-storage-blob/azure/storage/blob/_deserialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_deserialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_serialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_serialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_serialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_serialize.py
Outdated
Show resolved
Hide resolved
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vincenttran-msft
commented
Jan 9, 2024
sdk/storage/azure-storage-blob/azure/storage/blob/_deserialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_serialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_serialize.py
Outdated
Show resolved
Hide resolved
vincenttran-msft
commented
Jan 9, 2024
sdk/storage/azure-storage-blob/azure/storage/blob/_deserialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_encryption.py
Outdated
Show resolved
Hide resolved
jalauzon-msft
approved these changes
Jan 23, 2024
vincenttran-msft
merged commit 3372a74
into
Azure:feature/storage-blob-typing2
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Updated 1/11)
Remaining errors on:
_deserialize.py:azure\storage\blob_deserialize.py:159: error: Incompatible types in assignment (expression has type "Optional[BlobType]", variable has type "BlobType") [assignment]
azure\storage\blob_deserialize.py:169: error: Incompatible types in assignment (expression has type "Optional[datetime]", variable has type "datetime") [assignment]
azure\storage\blob_deserialize.py:171: error: Incompatible types in assignment (expression has type "Optional[int]", variable has type "int") [assignment]
azure\storage\blob_deserialize.py:173: error: Incompatible types in assignment (expression has type "Optional[bool]", variable has type "bool") [assignment]
azure\storage\blob_deserialize.py:177: error: Incompatible types in assignment (expression has type "Union[str, AccessTier, None]", variable has type "Optional[StandardBlobTier]") [assignment]
_download.py:Left seperate comments for them