Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyword Check #31823

Merged
merged 11 commits into from
Sep 7, 2023
+77 −3
Merged

Add Keyword Check #31823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
148b83f
[skip ci] Delete last YAML recordings
mccoyp Aug 17, 2023
f60d589
Merge remote-tracking branch 'upstream/main'
scbedd Aug 22, 2023
fc2b6cd
Merge remote-tracking branch 'upstream/main'
scbedd Aug 25, 2023
64740f3
add the classifier check. currently failing as none of the packages h…
scbedd Aug 26, 2023
0a377bc
update parse functionality to include keywords
scbedd Sep 5, 2023
88a4827
change from classifiers to keywords. utilize new parsing functionality.
scbedd Sep 5, 2023
4aa04fa
update to consume sdk_verify_keywords
scbedd Sep 6, 2023
5148fdd
add the check to analyze yaml now that we've updated the repo to alwa…
scbedd Sep 7, 2023
f9f0813
merge main
scbedd Sep 7, 2023
38c1413
update the description of the keyword verification script. still had …
scbedd Sep 7, 2023
74a36a7
need to call on the correct path.
scbedd Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update to consume sdk_verify_keywords
  • Loading branch information
@scbedd
scbedd committed Sep 6, 2023
commit 4aa04fa0b008a998e0b1a74978482a128733ffe8
2 changes: 1 addition & 1 deletion eng/tox/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ setenv =
deps =
{[base]deps}
commands =
sdk_verify_classifiers -t {tox_root}
sdk_verify_keywords -t {tox_root}


[testenv:breaking]
Expand Down
4 changes: 2 additions & 2 deletions tools/azure-sdk-tools/ci_tools/keywords_verify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ def entrypoint() -> None:
pkg_details = ParsedSetup.from_path(args.target)

if in_ci():
if not is_check_enabled(args.target_package, "pylint"):
if not is_check_enabled(args.target_package, "verify_keywords"):
logging.info(
f"Package {pkg_details.name} opts-out of pylint check."
f"Package {pkg_details.name} opts-out of keyword verification check."
)
exit(0)

Expand Down