Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the parameters log_training_metrics and log_validation_loss for object detection and instance segmentation #31479

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

bhimar
Copy link
Member

@bhimar bhimar commented Aug 4, 2023

Description

Expose the parameters log_training_metrics and log_validation_loss for object detection and instance segmentation

The test runs below use the JOS and azureml-automl-dnn-vision changes for exposing and setting these parameters.

Tests:

Scenario Run Notes
OD
individual 'Enable' run both params set to 'Enable'
individual 'enable' run both params set to 'enable', in HD driver script they appear as 'Enable'
individual 'Disable' run both params set to 'Disable
individual 'disable' run both params set to 'disable', in HD driver script they appear as 'Disable'
individual don't specify params run the params are not specified through SDK, so the MFE defaults are picked up: log_training_metrics == 'Enable' and log_validation_loss == 'Disable as in the HD driver script
Automode run both params are not present in the HD script, so they pick up the runtime defaults: log_training_metrics == 'Disable' and log_validation_loss == 'Enable'
IS
individual 'Enable' run both params set to 'Enable'
individual 'enable' run both params set to 'enable', in HD driver script they appear as 'Enable'
individual 'Disable' run both params set to 'Disable
individual 'disable' run both params set to 'disable', in HD driver script they appear as 'Disable'
individual don't specify params run the params are not specified through SDK, so the MFE defaults are picked up: log_training_metrics == 'Enable' and log_validation_loss == 'Disable as in the HD driver script
Automode run both params are not present in the HD script, so they pick up the runtime defaults: log_training_metrics == 'Disable' and log_validation_loss == 'Enable'

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. ML-AutoML AreaPath labels Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Thank you for your contribution @bhimar! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@bhimar bhimar changed the title Rbhimani/enable log params Expose the parameters log_training_metrics and log_validation_loss for object detection and instance segmentation Aug 7, 2023
@bhimar bhimar marked this pull request as ready for review August 7, 2023 21:06
Copy link
Contributor

@rdondera-microsoft rdondera-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the comprehensive tests. Be sure to get a review from an actual SDK expert too.

@needuv needuv merged commit ae2c36e into Azure:main Aug 8, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. ML-AutoML AreaPath
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants