Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EH typing for tracing #31432

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Fix EH typing for tracing #31432

merged 1 commit into from
Aug 2, 2023

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Aug 2, 2023 •
edited
Loading

Working on #31422 uncovered a typing bug in EH

azure/eventhub/_tracing.py:80: error: Incompatible types in assignment (expression has type "Optional[Type[AbstractSpan]]", variable has type "Type[AbstractSpan]")  [assignment]
azure/eventhub/_tracing.py:95: error: Incompatible types in assignment (expression has type "Optional[Type[AbstractSpan]]", variable has type "Type[AbstractSpan]")  [assignment]
azure/eventhub/_tracing.py:112: error: Incompatible types in assignment (expression has type "Optional[Type[AbstractSpan]]", variable has type "Type[AbstractSpan]")  [assignment]
azure/eventhub/_tracing.py:139: error: Incompatible types in assignment (expression has type "Optional[Type[AbstractSpan]]", variable has type "Type[AbstractSpan]")  [assignment]

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@kashifkhan kashifkhan merged commit d3add4e into main Aug 2, 2023
@kashifkhan kashifkhan deleted the eventhub_typing_fix branch August 2, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifkhan kashifkhan kashifkhan approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@swathipil swathipil Awaiting requested review from swathipil swathipil is a code owner

@l0lawrence l0lawrence Awaiting requested review from l0lawrence l0lawrence is a code owner

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmazuel @azure-sdk @kashifkhan