Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a type in identity #31431

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Add a type in identity #31431

merged 1 commit into from
Aug 2, 2023

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Aug 2, 2023

Somehow #31422 requires this to be happy. Otherwise:

azure/identity/_internal/pipeline.py:29: error: Need type annotation for "config"  [var-annotated]

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@lmazuel lmazuel merged commit e7a9aed into main Aug 2, 2023
@lmazuel lmazuel deleted the identity_typing branch August 2, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner

Assignees
No one assigned
Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmazuel @azure-sdk @xiangyan99