Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Proxy] Create HTTP clients at runtime to support dynamic certificate setup #30789

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jun 15, 2023

Description

Module-level, shared HTTP clients are more efficient but will be set up before SSL_CERT_DIR and REQUESTS_CA_BUNDLE are automatically set by the test proxy's setup script. This results in certificate errors when making requests to the test proxy if these environment variables aren't manually set beforehand in either a .env file or in the user's test-running environment.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added EngSys This issue is impacting the engineering system. test-proxy Anything relating to test-proxy requests or issues. labels Jun 15, 2023
@mccoyp mccoyp marked this pull request as ready for review June 27, 2023 20:46
@mccoyp mccoyp requested a review from scbedd June 27, 2023 20:57
@scbedd
Copy link
Member

scbedd commented Jul 20, 2023

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member

scbedd commented Jul 20, 2023

  • Additional Validation Builds Prior to Merge

storage
ml

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gravy. Thanks for the retry on azure-ai-ml! Once that's green we should merge this.

I'm excited to see this to go in! It'll be a big simplification for all our devs.

@mccoyp mccoyp merged commit e70aa6d into Azure:main Jul 21, 2023
@mccoyp mccoyp deleted the proxy-certs branch July 21, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system. test-proxy Anything relating to test-proxy requests or issues.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants