-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting up Python SDK for Personalizer #26296
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
…zure-sdk-for-python into personalizersdk
sdk/personalizer/azure-ai-personalizer/tests/test_configuration_async.py
Show resolved
Hide resolved
Added @pytest.mark.asyncio decorator for async tests.
…into personalizersdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the tests.yml is moved up a directory, we can run /azp run prepare-pipelines
to create the CI pipeline for your library.
authentication_policy=kwargs.pop("authentication_policy", _authentication_policy(credential, **kwargs)), | ||
**kwargs | ||
) | ||
self._default_language = kwargs.pop("default_language", None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default_language
is specific to the question answering client library, you can remove it. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
from azure.core.pipeline.policies import AzureKeyCredentialPolicy, AsyncBearerTokenCredentialPolicy | ||
from ._client import PersonalizerClient as PersonalizerClientGenerated | ||
|
||
__all__: List[str] = [] # Add all objects you want publicly available to users at this package level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a duplicate, it's defined on L83 #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks!
DESCRIPTION: | ||
This sample demos sending a rank and reward call to personalizer for multi-slot configuration. | ||
USAGE: python multi_slot_rank_actions_and_reward_events_async.py | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should describe the environment variables needed to run this sample under the comment header. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
return cast(Iterator[bytes], deserialized) | ||
|
||
@distributed_trace | ||
def import_method(self, body: IO, **kwargs: Any) -> None: # pylint: disable=inconsistent-return-statements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import
is a keyword in Python so it looks like the generator is appending "method" to the method name. I missed this on the first review but we should probably give this a better name. Can you rename it through the swagger transform? Should look something like:
directive:
- rename-operation:
from: Model_Import
to: Model_ImportModel
This will rename it to import_model (or whatever it should be named) #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. Fixed.
ServiceDirectory: personalizer | ||
MatrixReplace: | ||
- TestSamples=.*/true | ||
Clouds: Canary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to run tests in Canary (it doesn't look like we do in the other languages).
Clouds: Canary |
@@ -0,0 +1,18 @@ | |||
trigger: none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be up one level: sdk/personalizer/tests.yml #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
692b9c0
to
ef96d81
Compare
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
Added the comment in github pr. In reply to: 1133773653 |
d4df8e0
to
4859d6d
Compare
API change check APIView has identified API level changes in this PR and created following API reviews. |
All comments have been addressed. This PR is being replaced with a different PR: #26719 |
Abandoning this PR as it had some leaked apikeys (the keys were rotated and so the risk is mitigated). This PR is superceded by this one: #26719 |
Release sql microsoft.sql 2023 05 01 preview (Azure#26289) * Adds base for updating Microsoft.Sql from version preview/2023-02-01-preview to version 2023-05-01-preview * Updates readme * Updates API version in new specs and examples * Adding JobPrivateEndpoints API to version 2023-05-01-preview (Azure#24902) * Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview * Updates readme * Updates API version in new specs and examples * add mi refresh API (Azure#24093) * add mi refresh API * remove stray character * add examples * fix lro error * fix lro error only in example * fixing prettier issue * Test commit - adding error schema * Test2 * Test - changing error type * Revert "Test - changing error type" This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064. * Reverting 3 test commits * Test - adding commong error type reference * fix type format errors --------- Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> * Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221) * Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132) * Added the swagger spec and example json files for failvoer group API update in V2023-020-1 * Corrected the FailoverGroupGet.json example * Updated the auto-generated FailoverGroups.json Fixed FailoverGroups.json swagger arm-id attribute for databases field * Added the missing headers field manually * Fix FailoverGroups.json --------- Co-authored-by: Sharan Singh <sharanlobana@gmail.com> * Changes to Location Capabilities (Azure#24209) * Loc cap changes * removing changes not related to my changes in dsmain * DAG API 2023-02-01 (Azure#24108) * add new dag api version * Update swagger * Update swagger * patch resource * make replicationMode writable * Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224) * Add FreeLimitExhaustion Capability in 2023-02-01-preview API * Change property from name to exhaustionBehaviorType * generate swagger for LocationCapabilites (Azure#24290) * inital commit for LTR Policy Immutability (Azure#24347) * inital commit for immutable ltr backups (Azure#24349) * Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305) * Update swagger files for Server API * Add v5 tag for Servers * Restore none for minimal TLS version * Add auto rotation param to databases api (Azure#24339) * Add auto rotation param to databases api * add armid * Adding IsFreemium and CreateTime to Get MI API (Azure#24239) * job private endpoint swagger * rerun pipelines * adding job private endpoints to readme * rerun pipelines * trying to fix lint errors * fixing typos - singular resource name and description. * adding arm-id * Moving files to the new version; no changes to the files themselves. * adding job agent private endpoints to readme --------- Co-authored-by: Jeremy Frosti <111934615+jeremyfrosti@users.noreply.github.com> Co-authored-by: guptanitish-ms <68623376+guptanitish-ms@users.noreply.github.com> Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> Co-authored-by: lobashh <56324552+lobashh@users.noreply.github.com> Co-authored-by: Sharan Singh <sharanlobana@gmail.com> Co-authored-by: Aleksand4rZivanovic <60347245+Aleksand4rZivanovic@users.noreply.github.com> Co-authored-by: a-lazarlazic <106240189+a-lazarlazic@users.noreply.github.com> Co-authored-by: mykolian <34487118+mykolian@users.noreply.github.com> Co-authored-by: Srna Nikolic <133877309+srnanikolicmdcs@users.noreply.github.com> Co-authored-by: rebeccaxu-ms <104461363+rebeccaxu-ms@users.noreply.github.com> Co-authored-by: LeiWang3 <84884417+LeiWang3@users.noreply.github.com> Co-authored-by: viparek <78561564+viparek@users.noreply.github.com> Co-authored-by: Nikola Mirkovic <135128634+nmirkovic-microsoft@users.noreply.github.com> * DAG API 2023-05-01 for MI First (Azure#25638) * mi first dag api 2023-05-01 * adding x-ms-identifiers * adding job step and target group apis to version 2023-05-01-preview (Azure#25689) * adding job step and target group apis to versoin 2023-05-01-preview * remove required credential --------- Co-authored-by: Ray Boyd <rayboyd@microsoft.com> * updating location capabilities for 2023-05-01-preview (Azure#25539) Co-authored-by: Ray Boyd <rayboyd@microsoft.com> * Updating Instance Pool swagger for 2023-05-01-preview (Azure#25580) * Updating Instance Pool swagger for 2023-05-01-preview * Add format specification * Update examples --------- Co-authored-by: Kosta Bizetic <bizetickosta@microsoft.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Add Archive option to LTR Policy and LTR Backup for SQL DB (Azure#25799) * added changes * fix swagger validation failures * adding fixes * added more changes * added fixes * fixed LintDiff * added changes * fix lintDiff * Swagger validations for serverless parameters added in SQL API (Azure#25852) * Swagger validations for serverless parameters added in SQL API * Fixing spellcheck in example file * Fix LintDiff error --------- Co-authored-by: Yash Udasi <yudasi@microsoft.com> * Add AAD support to job agents version 2023-05-01-preview (Azure#25553) * adding job agent identity support to 2023-05-01-preview * updated swagger with just aad changes --------- Co-authored-by: Ray Boyd <rayboyd@microsoft.com> * Dev/sonjac/ltr api update (Azure#25701) * Adding generated files. * Fixing swagger errors. * Managed Instance swagger to support Authentication Metadata (Azure#25795) * generated swagger * fixed prettier: * fixed minor stuff * swagger fixes * added missing example file * removed unused file * externalgovernance fixes * minor fixes * missing character * Adding JobAgents API with SKU support to version 2023-05-01-preview (Azure#24995) * Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview * Updates readme * Updates API version in new specs and examples * add mi refresh API (Azure#24093) * add mi refresh API * remove stray character * add examples * fix lro error * fix lro error only in example * fixing prettier issue * Test commit - adding error schema * Test2 * Test - changing error type * Revert "Test - changing error type" This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064. * Reverting 3 test commits * Test - adding commong error type reference * fix type format errors --------- Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> * Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221) * Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132) * Added the swagger spec and example json files for failvoer group API update in V2023-020-1 * Corrected the FailoverGroupGet.json example * Updated the auto-generated FailoverGroups.json Fixed FailoverGroups.json swagger arm-id attribute for databases field * Added the missing headers field manually * Fix FailoverGroups.json --------- Co-authored-by: Sharan Singh <sharanlobana@gmail.com> * Changes to Location Capabilities (Azure#24209) * Loc cap changes * removing changes not related to my changes in dsmain * DAG API 2023-02-01 (Azure#24108) * add new dag api version * Update swagger * Update swagger * patch resource * make replicationMode writable * Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224) * Add FreeLimitExhaustion Capability in 2023-02-01-preview API * Change property from name to exhaustionBehaviorType * generate swagger for LocationCapabilites (Azure#24290) * inital commit for LTR Policy Immutability (Azure#24347) * inital commit for immutable ltr backups (Azure#24349) * Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305) * Update swagger files for Server API * Add v5 tag for Servers * Restore none for minimal TLS version * Add auto rotation param to databases api (Azure#24339) * Add auto rotation param to databases api * add armid * Adding IsFreemium and CreateTime to Get MI API (Azure#24239) * Updated the examples for LTR Policies and LTR Backups (Azure#24821) * Updated the examples for LTR Policies and LTR Backups * Not sure why makeBackupsImmutable got deleted * swagger changes * api version changed * adding identity files to the version on review * change of getjobagent * change test * nit fix * Changes to use SKU name to specify SLO * Changes for job agent update SLO with 2023-05-01 version * removing files of 2023-02-01 * fix * removing changes on JobAgents 2023-02-01 --------- Co-authored-by: Jeremy Frosti <111934615+jeremyfrosti@users.noreply.github.com> Co-authored-by: guptanitish-ms <68623376+guptanitish-ms@users.noreply.github.com> Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> Co-authored-by: lobashh <56324552+lobashh@users.noreply.github.com> Co-authored-by: Sharan Singh <sharanlobana@gmail.com> Co-authored-by: Aleksand4rZivanovic <60347245+Aleksand4rZivanovic@users.noreply.github.com> Co-authored-by: a-lazarlazic <106240189+a-lazarlazic@users.noreply.github.com> Co-authored-by: mykolian <34487118+mykolian@users.noreply.github.com> Co-authored-by: Srna Nikolic <133877309+srnanikolicmdcs@users.noreply.github.com> Co-authored-by: rebeccaxu-ms <104461363+rebeccaxu-ms@users.noreply.github.com> Co-authored-by: LeiWang3 <84884417+LeiWang3@users.noreply.github.com> Co-authored-by: viparek <78561564+viparek@users.noreply.github.com> Co-authored-by: Nikola Mirkovic <135128634+nmirkovic-microsoft@users.noreply.github.com> * added swagger spec and example json files for failovergroup api (Azure#25837) * Updating Managed Instance swagger for 2023-05-01-preview (Azure#26098) * Modifying ManagedInstances.json and corresponding examples * Remove example * Fix syntax errors * Swagger API changes to support PUT and PATCH to update replication link type (Azure#25690) * Add Swagger files for Replication Link Update Link Type * resolve validation error * Modify property description * resolve lint errors * Reverting MI change for readme to fix merge conflict with main (Azure#26296) --------- Co-authored-by: jacobopac <104868942+jacobopac@users.noreply.github.com> Co-authored-by: guptanitish-ms <68623376+guptanitish-ms@users.noreply.github.com> Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> Co-authored-by: lobashh <56324552+lobashh@users.noreply.github.com> Co-authored-by: Sharan Singh <sharanlobana@gmail.com> Co-authored-by: Aleksand4rZivanovic <60347245+Aleksand4rZivanovic@users.noreply.github.com> Co-authored-by: a-lazarlazic <106240189+a-lazarlazic@users.noreply.github.com> Co-authored-by: mykolian <34487118+mykolian@users.noreply.github.com> Co-authored-by: Srna Nikolic <133877309+srnanikolicmdcs@users.noreply.github.com> Co-authored-by: rebeccaxu-ms <104461363+rebeccaxu-ms@users.noreply.github.com> Co-authored-by: LeiWang3 <84884417+LeiWang3@users.noreply.github.com> Co-authored-by: viparek <78561564+viparek@users.noreply.github.com> Co-authored-by: Nikola Mirkovic <135128634+nmirkovic-microsoft@users.noreply.github.com> Co-authored-by: ms-mjovkovic <140057686+ms-mjovkovic@users.noreply.github.com> Co-authored-by: Ray Boyd <rayboyd30@gmail.com> Co-authored-by: Ray Boyd <rayboyd@microsoft.com> Co-authored-by: Kosta Bizetić <kosta.bizetic@gmail.com> Co-authored-by: Kosta Bizetic <bizetickosta@microsoft.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: CelinaJiangJXY <124339390+CelinaJiangJXY@users.noreply.github.com> Co-authored-by: Yash Udasi <36713809+Yashu1818@users.noreply.github.com> Co-authored-by: Yash Udasi <yudasi@microsoft.com> Co-authored-by: Sonja Ciric <78421408+sonjaciric@users.noreply.github.com> Co-authored-by: Nebojsa Savic <112883615+nesavicMSFT@users.noreply.github.com> Co-authored-by: alejandro182 <140119874+alejandro182@users.noreply.github.com> Co-authored-by: saljain0101 <145347114+saljain0101@users.noreply.github.com> Co-authored-by: Marko Milovanovic <147002062+mmilovanovic95@users.noreply.github.com> Co-authored-by: Archana Sahoo <109509626+archanasahoo22@users.noreply.github.com>
Description
Python SDK for Azure Cognitive Services Personalizer.
Swagger link: TBD
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines