Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] Remove continuation_token kwarg #25298

Merged
merged 2 commits into from
Jul 19, 2022
Merged

[formrecognizer] Remove continuation_token kwarg #25298

merged 2 commits into from
Jul 19, 2022

Conversation

catalinaperalta
Copy link
Member

Removes continuation_token keyword argument.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-formrecognizer

@catalinaperalta catalinaperalta marked this pull request as ready for review July 19, 2022 22:13
@catalinaperalta catalinaperalta merged commit a844c36 into Azure:main Jul 19, 2022
@catalinaperalta catalinaperalta deleted the removeContToken branch July 19, 2022 23:42
iscai-msft added a commit that referenced this pull request Jul 20, 2022
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
09dd220 
…into version_tolerant_models

* 'main' of https://github.com/Azure/azure-sdk-for-python: (259 commits)
  Sync eng/common directory with azure-sdk-tools for PR 3702 (#25309)
  remove continuation_token kwarg (#25298)
  Print additional result summary formats to pipelines UI (#25306)
  Increment package version after release of azure-ai-language-questionanswering (#25303)
  [textanalytics] refactor pollers + add TA poller protocol (#25275)
  Remove needs-triage label if it is assigned (#25302)
  Update casing for 'verison' (#25197)
  don't drop 3.6 yet (#25293)
  always check proxy availability (#25291)
  bump python version in autorest pipeline check (#25288)
  add needs-triage labeler (#25289)
  [Confidential Ledger] GA Data Plane SDK (#24900)
  [QA] support AAD auth (#25256)
  Fixed the var name (#25277)
  Storage File Datalake test (test_list_paths_with_max_per_page) improvement (#25240)
  [formrecognizer] Add a type for target authorization for copy requests (#25268)
  disable labeler (#25278)
  [textanalytics] use commits for swagger in generation readme (#25246)
  [textanalytics] add multi label classify bespoke method (#25009)
  [Storage] Migrate `test_blob_api_version` and `test_blob_client` to test proxy (#25272)
  ...
jeremydvoss pushed a commit to jeremydvoss/azure-sdk-for-python that referenced this pull request Jul 21, 2022
@catalinaperalta @jeremydvoss
remove continuation_token kwarg (Azure#25298)
e266034
@catalinaperalta catalinaperalta mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

Assignees
No one assigned
Labels
Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catalinaperalta @azure-sdk @kristapratico