Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR applicationinsights/resource-manager] Workbook Type: Removed a location parameter since it is routed by ARM (tracked resource) #2447

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,14 @@ def __init__(self, client, config, serializer, deserializer):
self.config = config

def get(
self, resource_group_name, resource_name, location, custom_headers=None, raw=False, **operation_config):
self, resource_group_name, resource_name, custom_headers=None, raw=False, **operation_config):
"""Get a single workbook by its resourceName.

:param resource_group_name: The name of the resource group.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
:type resource_name: str
:param location: The name of location where workbook is stored.
:type location: str
:param dict custom_headers: headers that will be added to the request
:param bool raw: returns the direct response alongside the
deserialized response
Expand All @@ -69,7 +67,6 @@ def get(

# Construct parameters
query_parameters = {}
query_parameters['location'] = self._serialize.query("location", location, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')

# Construct headers
Expand Down Expand Up @@ -102,16 +99,14 @@ def get(
get.metadata = {'url': '/subscriptions/{subscriptionId}/resourceGroup/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}'}

def delete(
self, resource_group_name, resource_name, location, custom_headers=None, raw=False, **operation_config):
self, resource_group_name, resource_name, custom_headers=None, raw=False, **operation_config):
"""Delete a workbook.

:param resource_group_name: The name of the resource group.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
:type resource_name: str
:param location: The name of location where workbook is stored.
:type location: str
:param dict custom_headers: headers that will be added to the request
:param bool raw: returns the direct response alongside the
deserialized response
Expand All @@ -133,7 +128,6 @@ def delete(

# Construct parameters
query_parameters = {}
query_parameters['location'] = self._serialize.query("location", location, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')

# Construct headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,12 @@ def __init__(self, client, config, serializer, deserializer):
self.config = config

def list_by_resource_group(
self, resource_group_name, location, category, tags=None, can_fetch_content=None, custom_headers=None, raw=False, **operation_config):
self, resource_group_name, category, tags=None, can_fetch_content=None, custom_headers=None, raw=False, **operation_config):
"""Get all Workbooks defined within a specified resource group and
category.

:param resource_group_name: The name of the resource group.
:type resource_group_name: str
:param location: The name of location where workbook is stored.
:type location: str
:param category: Category of workbook to return. Possible values
include: 'workbook', 'TSG', 'performance', 'retention'
:type category: str or
Expand Down Expand Up @@ -76,7 +74,6 @@ def list_by_resource_group(

# Construct parameters
query_parameters = {}
query_parameters['location'] = self._serialize.query("location", location, 'str')
query_parameters['category'] = self._serialize.query("category", category, 'str')
if tags is not None:
query_parameters['tags'] = self._serialize.query("tags", tags, '[str]', div=',')
Expand Down