Update aggregate-report to use common credscan yml and update baseline file #23090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
changed the title
sima-zhu
requested review from
lmazuel,
mccoyp,
YalinLi0312,
scbedd,
weshaggard and
benbp
as code owners
weshaggard
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Change looks good but I assume you want to wait for Azure/azure-sdk-tools#2775 and ensure the baseline matches that tool version.
weshaggard
reviewed
Feb 17, 2022
sima-zhu
force-pushed
the
update_baseline
branch
from
f6f82d0
to
61ebd23
Compare
mccoyp
approved these changes
Feb 18, 2022
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Feb 18, 2022
4 lang PRs: Java: Azure/azure-sdk-for-java#27152 .NET: Azure/azure-sdk-for-net#27054 Python: Azure/azure-sdk-for-python#23090 JS: Azure/azure-sdk-for-js#20413 The PR includes the link of all testing.
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 4, 2022
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (601 commits) pin markupsafe (Azure#23132) [Communication] - phone-numbers - Implement a phone number pool for update capabilities live tests (Azure#23116) Add timeout on Invoke-request call (Azure#23120) Sync eng/common directory with azure-sdk-tools for PR 2775 (Azure#23115) Update aggregate-report to use common credscan yml and update baseline file (Azure#23090) Update CHANGELOG.md (Azure#23119) [Issue helper] Update owner list (Azure#23079) [KV] Update changelogs for stable releases (Azure#23053) code and test (Azure#23047) [recoveryservicesbackup] fix multiple pages paging (Azure#23089) rerecord failing tests for fr (Azure#23107) [Test Proxy] Remove unnecessary git SHA fetch (Azure#23113) [Storage] Fix some mypy typing errors and typing imports (Azure#23098) Add logic to generate docs.ms ToC (Azure#23086) Fix broken link in tests.md (Azure#23110) Enable apistub gen step (Azure#23088) pin version of storage blob used for testing (Azure#23109) ensure that py36 can start the process properly (Azure#23108) fix cspell issues for azure-communication identity (Azure#22636) (Azure#23085) code and test (Azure#23077) ...
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
This is pre-requisite of PR:
https://github.com/Azure/azure-sdk-tools/pull/2775/files
We are ready to use credscan stable version. Put existing issues into baseline. Team will work on baseline file.
Generate baseline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1376421&view=results
Legacy version: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1376511&view=results
New stable version: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1376784&view=results
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines