-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aggregate-report to use common credscan yml and update baseline file #23090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good but I assume you want to wait for Azure/azure-sdk-tools#2775 and ensure the baseline matches that tool version.
f6f82d0
to
61ebd23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for regenerating the baseline, Sima!
4 lang PRs: Java: Azure/azure-sdk-for-java#27152 .NET: Azure/azure-sdk-for-net#27054 Python: Azure/azure-sdk-for-python#23090 JS: Azure/azure-sdk-for-js#20413 The PR includes the link of all testing.
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (601 commits) pin markupsafe (Azure#23132) [Communication] - phone-numbers - Implement a phone number pool for update capabilities live tests (Azure#23116) Add timeout on Invoke-request call (Azure#23120) Sync eng/common directory with azure-sdk-tools for PR 2775 (Azure#23115) Update aggregate-report to use common credscan yml and update baseline file (Azure#23090) Update CHANGELOG.md (Azure#23119) [Issue helper] Update owner list (Azure#23079) [KV] Update changelogs for stable releases (Azure#23053) code and test (Azure#23047) [recoveryservicesbackup] fix multiple pages paging (Azure#23089) rerecord failing tests for fr (Azure#23107) [Test Proxy] Remove unnecessary git SHA fetch (Azure#23113) [Storage] Fix some mypy typing errors and typing imports (Azure#23098) Add logic to generate docs.ms ToC (Azure#23086) Fix broken link in tests.md (Azure#23110) Enable apistub gen step (Azure#23088) pin version of storage blob used for testing (Azure#23109) ensure that py36 can start the process properly (Azure#23108) fix cspell issues for azure-communication identity (Azure#22636) (Azure#23085) code and test (Azure#23077) ...
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
This is pre-requisite of PR:
https://github.com/Azure/azure-sdk-tools/pull/2775/files
We are ready to use credscan stable version. Put existing issues into baseline. Team will work on baseline file.
Generate baseline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1376421&view=results
Legacy version: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1376511&view=results
New stable version: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1376784&view=results
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines