Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to central fake secret store #23064

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Point to central fake secret store #23064

merged 1 commit into from
Feb 15, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Feb 15, 2022

Description

Adds references to our central location for storing fake credentials, devtools_testutils/fake_credentials.py.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • N/A Pull request includes test coverage for the included changes.

@mccoyp mccoyp requested a review from lmazuel February 15, 2022 17:58
@mccoyp mccoyp merged commit 29596e3 into main Feb 15, 2022
@mccoyp mccoyp deleted the credscan-fake-creds branch February 15, 2022 18:05
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants